Use PVS-Studio Analyzer

https://www.viva64.com/en/pvs-studio/

tools/linuxdeployqt/main.cpp

@@ -251,7 +251,7 @@ int main(int argc, char **argv)
     QString desktopExecEntry = "";
     QString desktopIconEntry = "";
 
-    if (argc > 1) {
+    if (argc > 2) {
         /* If we got a desktop file as the argument, try to figure out the application binary from it.
          * This has the advantage that we can also figure out the icon file this way, and have less work
          * to do when using linuxdeployqt. */

tools/linuxdeployqt/shared.cpp

@@ -514,7 +514,7 @@ LibraryInfo parseLddLibraryLine(const QString &line, const QString &appDirPath,
             }
             qtPath += (currentPart + "/");
 
-        } if (state == LibraryName) {
+        } else if (state == LibraryName) {
             name = currentPart;
             info.isDylib = true;
             info.libraryName = name;
@@ -785,7 +785,7 @@ QString runPatchelf(QStringList options)
 bool patchQtCore(const QString &path, const QString &variable, const QString &value)
 {
     return true; // ################################### Disabling for now since using qt.conf
-    QFile file(path);
+    /* QFile file(path);
     if (!file.open(QIODevice::ReadWrite)) {
         LogWarning() << QString::fromLatin1("Unable to patch %1: %2").arg(
                     QDir::toNativeSeparators(path), file.errorString());
@@ -828,6 +828,7 @@ bool patchQtCore(const QString &path, const QString &variable, const QString &va
         return false;
     }
     return true;
+    */
 }
 
 void changeIdentification(const QString &id, const QString &binaryPath)