TianZD/linuxdeployqt
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve argument parser user experience

Browse Source 
See https://github.com/probonopd/linuxdeployqt/issues/256#issuecomment-373916136

The argument parser requires flags expecting a payload to be passed in
the form -arg=payload. If not, it fails to recognize them and falsely
reports "argument must not start with --". These usability issues
should be gone with these two minor changes.
This commit is contained in:
TheAssassin
2018-03-17 13:27:24 +01:00
parent c01cf7727d
commit 8b484dabec
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/linuxdeployqt/main.cpp
+3 -3
View File
@@ -416,11 +416,11 @@ int main(int argc, char **argv)
LogDebug() << "Argument found:" << argument; LogDebug() << "Argument found:" << argument;
int index = argument.indexOf("="); int index = argument.indexOf("=");
extraQtPlugins = QString(argument.mid(index + 1)).split(","); extraQtPlugins = QString(argument.mid(index + 1)).split(",");
} else if (argument.startsWith("-")) { } else if (argument.startsWith("--")) {
LogError() << "Error: arguments must not start with --, only -" << "\n"; LogError() << "Error: arguments must not start with --, only -:" << argument << "\n";
return 1; return 1;
} else { } else {
LogError() << "Unknown argument" << argument << "\n"; LogError() << "Unknown argument:" << argument << "\n";
return 1; return 1;
} }
} }